This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
Kad eachbin fix #1052
Closed
Kad eachbin fix #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zelig
suggested changes
Dec 13, 2018
There was a problem hiding this comment.
The correct suhbscriptions need the correct kademlia depth function (Louis PR), so its better to have this pending merge of #1051
Once again, the spec for pull syncing is:
- REPLICATION: peers in nearest neighborhood should get all chunks that fall within the nearest neighbourhood; i.e.. subscribe to bins from depth upto
MaxProxDisplay; - ROUTING: peers outside your nearest neighborhood should only get chunks that are CLOSER to them than to us; i.e., subscribe to the bin they belong.
To build up kademlia, no need to use either Register or SuggestPeer, you just need to call On
with the peer contructed with the desired address
nolash
reviewed
Dec 13, 2018
zelig
suggested changes
Dec 14, 2018
holisticode
force-pushed
the
kad-eachbin-fix
branch
from
2493682 to
c305a3e
Compare
53 tasks
zelig
reviewed
Dec 19, 2018
swarm/network/kademlia_test.go
Outdated
| @@ -31,6 +32,10 @@ import ( | |||
| "github.com/ethereum/go-ethereum/swarm/pot" | |||
| ) | |||
|
|
|||
| var ( | |||
There was a problem hiding this comment.
If we need this at all, this is what loglevels are for. Please use that
|
Re-opened upstream as ethereum/go-ethereum#18338 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix a flaw in kademlia.EachBin
WIP