This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
swarm/network/stream: fix delivery test errors #1170
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix stream capability problems reported on travis https://travis-ci.org/ethersphere/go-ethereum/jobs/485364722#L808.
The problem is that in swarm/network/stream tests we do not have "stream" capability for nodes, but in RequestFromPeers method check for it. This is not a problem on production since every peer that is in Registry.peers must have "stream" capability, which is guaranteed by the p2p package. So this check can be safely removed.
I was not able to reproduce the issue locally, only on Travis, and with this change, multiple travis runs did not produce any errors.