swap: Incentives prices #1587
swap: Incentives prices #1587
Conversation
holisticode
requested review from
zelig,
ralph-pichler,
vojtechsimetka,
mortelli and
Eknir
| @@ -658,13 +659,13 @@ func (sp *StreamerPrices) Price(msg interface{}) *protocols.Price { | |||
| // Instead of hardcoding the price, get it | |||
| // through a function - it could be quite complex in the future | |||
| func (sp *StreamerPrices) getRetrieveRequestMsgPrice() uint64 { | |||
| return RetrieveRequestMsgPrice | |||
| return swap.RetrieveRequestMsgPrice | |||
There was a problem hiding this comment.
Should we update the comment on these functions?
There was a problem hiding this comment.
To what?
We don't have an oracle for the actual honey price per message type yet, so this function comment is still correct?
| } | ||
|
|
||
| cheque := chequeMsg.Cheque | ||
| cheque := msg.Cheque | ||
| if cheque.Contract != sp.contractAddress { |
There was a problem hiding this comment.
Wouldn't it be wise to rename cheque.Contract to cheque.contractAddress or cheque.address?
Not a big issue for me, but I noticed this already in lake Balaton and had to look twice here as well what exactly cheque.Contract is.
There was a problem hiding this comment.
I agree it is confusing.
Nevertheless there is apparently a go guideline which suggests to not add the type into a variable name. Contract is of type common.Address.
Nevertheless we are not very consistent with this notion either, because Owner.address is also a common.Address - I would rather like to change that name. Any suggestion?
swap/swap.go
Outdated
| @@ -40,17 +40,18 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
There was a problem hiding this comment.
Could you clarify for me why these constants are in swap.go and not in defaults.go? What is the purpose of defaults.go and how do we decide when to put constants there versus in a different file?
There was a problem hiding this comment.
Good catch. It should all be there in defaults.go
* swap: correct price handling and reset balances * swap: conversion to wei on cheque creation; cleanup * swap: bug fixes and TestEmitCheque * swap: addressed PR comments * swap: minor fixes due to PR comments
* swap: correct price handling and reset balances * swap: conversion to wei on cheque creation; cleanup * swap: bug fixes and TestEmitCheque * swap: addressed PR comments * swap: minor fixes due to PR comments
* swap: correct price handling and reset balances * swap: conversion to wei on cheque creation; cleanup * swap: bug fixes and TestEmitCheque * swap: addressed PR comments * swap: minor fixes due to PR comments
* swap: correct price handling and reset balances * swap: conversion to wei on cheque creation; cleanup * swap: bug fixes and TestEmitCheque * swap: addressed PR comments * swap: minor fixes due to PR comments
* swap: correct price handling and reset balances * swap: conversion to wei on cheque creation; cleanup * swap: bug fixes and TestEmitCheque * swap: addressed PR comments * swap: minor fixes due to PR comments
This PR adds a consistent pricing design to swap.
The idea is that internally, swap uses an own unit of account (
honey), which is then converted to a currency (e.g. wei, could be any other) when the cheque is being created.The concept of a price oracle is introduced. In order to minimize handshakes, negotiations etc. we postulate that there would be an oracle which nodes query to get the conversion from
honeytowei.For the time being this will be a hardcoded conversion of 1:1.