This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
protocols, swap: drop unincentivized peers when sending/receiving messages #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uncs if this error appears
|
even though i still have to add a test for this, i am going to preliminary request reviews from @Eknir and @santicomp2014 as well |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the code in the sending and receiving messages functions so that peers are dropped when they are unincentivized (when the node running is not).
This can happen if the peer in question is registered in other protocols but not in SWAP.
The benefit of this change is to avoid useless message exchanges that are going to be dropped every time they accounting hook is called.
closes #1917