Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Nimbus can't run when slot time is below 12s #100

Merged
merged 11 commits into from
Jul 14, 2023
Merged

fix: Nimbus can't run when slot time is below 12s #100

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
de3c663
updating source for fork
parithosh Jun 26, 2023
3af93e3
updating readme
parithosh Jun 26, 2023
e6f977e
fixing package
parithosh Jun 26, 2023
64e21db
fixing indentation
parithosh Jun 27, 2023
edd529c
Merge branch 'kurtosis-tech:main' into master
parithosh Jun 29, 2023
bfa110f
switching default images to latest
parithosh Jul 3, 2023
e240e7a
changing image
parithosh Jul 3, 2023
f939769
Merge branch 'kurtosis-tech:main' into master
parithosh Jul 7, 2023
f8f1f3c
adding nimbus restriction
parithosh Jul 7, 2023
85a5944
add nimbus const
parithosh Jul 7, 2023
0291aa5
Merge branch 'main' into master
parithosh Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/package_io/parse_input.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ DEFAULT_CL_IMAGES = {

BESU_NODE_NAME = "besu"
NETHERMIND_NODE_NAME = "nethermind"
NIMBUS_NODE_NAME = "nimbus"

ATTR_TO_BE_SKIPPED_AT_ROOT = ("network_params", "participants")

Expand Down Expand Up @@ -52,6 +53,9 @@ def parse_input(input_args):
if index == 0 and el_client_type in (BESU_NODE_NAME, NETHERMIND_NODE_NAME):
fail("besu/nethermind cant be the first participant")

if cl_client_type in (NIMBUS_NODE_NAME) and (result["network_params"]["seconds_per_slot"] < 12):
parithosh marked this conversation as resolved.
Show resolved Hide resolved
fail("nimbus can't be run with slot times below 12 seconds")

el_image = participant["el_client_image"]
if el_image == "":
default_image = DEFAULT_EL_IMAGES.get(el_client_type, "")
Expand Down