Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove overrides #357

Merged
merged 15 commits into from
Nov 30, 2023
Merged

feat: Remove overrides #357

merged 15 commits into from
Nov 30, 2023

Conversation

parithosh
Copy link
Member

Removes overrides we needed in place to support verkle until transition support was added. The support has now been added.

@barnabasbusa
Copy link
Contributor

Could we start having an example dir with all the example yaml files these should work? I'm kinda lost in terms of what geth/lodestar versions I should be testing the current latest petra stuff.

examples/verkle.yaml Outdated Show resolved Hide resolved
src/participant_network.star Outdated Show resolved Hide resolved
@barnabasbusa
Copy link
Contributor

Lets block this PR till we have all ELs working with transition, else they might want to test verkle genesis still.

@parithosh
Copy link
Member Author

parithosh commented Nov 29, 2023

Lets block this PR till we have all ELs working with transition, else they might want to test verkle genesis still.

ah i'd make the the case we shouldnt as ELs can use the PR to begin testing and finding bugs in their transition :D
geth is ready and would most likely benefit from this PR. i.e = failing with your client here is a good test to fix bugs

@parithosh
Copy link
Member Author

LGTM!

@barnabasbusa barnabasbusa merged commit 60a7529 into main Nov 30, 2023
9 checks passed
@barnabasbusa barnabasbusa deleted the update-verkle-transition branch November 30, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants