-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add initial support for Blobscan #363
Conversation
can you pls run |
Can you make sure your commits are signed? |
Co-authored-by: Tedi Mitiku <[email protected]>
9134124
to
b854ae3
Compare
@barnabasbusa I have addressed your comments and removed unrelated changes. Commits are now squashed and signed. |
Could you please add some docs regarding blobscan in the readme? |
@barnabasbusa I removed blobscan from |
Would blobscan require a dora instance? It looks like you are passing dora url to blobscan. Would blobscan be able to operate without dora? If blobscan won't work without dora, then might worth adding a check there somewhere. |
@barnabasbusa Yes! Blobscan can actually run without dora. I am removing the dependency and adding a comment about it |
Would actually be good if you would use dora if its available, and don't use it if it is not. Sorry for the possible misunderstanding. I think its good to have all functionality if Dora is available. |
Please add blobscan to readme line 265 too. |
852384f
to
e6d009e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🤖 I have created a release *beep* *boop* --- ## [1.1.0](1.0.0...1.1.0) (2023-11-30) ### Features * Add adminer ([#295](#295)) ([99b5913](99b5913)) * Add broadcaster ([#355](#355)) ([0f9c3aa](0f9c3aa)) * add custom label configuration option ([#375](#375)) ([82ec85e](82ec85e)) * add custom labels ([#340](#340)) ([789ed8e](789ed8e)) * add dencun example, bump teku mem, update mev-relay postgres name ([#369](#369)) ([1097531](1097531)) * Add Ethereum Metrics Exporter Dash ([#338](#338)) ([3ce9a78](3ce9a78)) * Add initial support for Blobscan ([#363](#363)) ([837fb97](837fb97)) * add prometheus custom configuration for participants ([#354](#354)) ([e9bbc7d](e9bbc7d)) * added a gitpod badge ([#356](#356)) ([e273993](e273993)) * Allow verkle to be at genesis or post genesis ([60a7529](60a7529)) * differentiate builder ec by suffixing it with '-builder' ([#347](#347)) ([c558cb2](c558cb2)) ### Bug Fixes * add java opts for besu ([#346](#346)) ([8aa88e3](8aa88e3)) * blobscan lint error ([#374](#374)) ([32f862b](32f862b)) * builder args incorrectly configured ([#343](#343)) ([66e73fb](66e73fb)) * network params setting invalid value for min/max configs ([#353](#353)) ([764b7dc](764b7dc)) * update validator reward address ([#350](#350)) ([57f82c0](57f82c0)) * Use unused accounts for mev flood ([#359](#359)) ([286654c](286654c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
No description provided.