Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump max mem limit for nimbus on holesky #439

Merged
merged 3 commits into from
Jan 8, 2024
Merged

fix: bump max mem limit for nimbus on holesky #439

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1816409
fix: bump max mem limit for nimbus on holesky
barnabasbusa Jan 8, 2024
5482e3e
fix memory override values
barnabasbusa Jan 8, 2024
4e466d1
fix lint
barnabasbusa Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/cl/nimbus/nimbus_launcher.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ BEACON_METRICS_PORT_NUM = 8008
# The min/max CPU/memory that the beacon node can use
BEACON_MIN_CPU = 50
BEACON_MAX_CPU = 1000
BEACON_MIN_MEMORY = 128
BEACON_MIN_MEMORY = 256
BEACON_MAX_MEMORY = 1024

DEFAULT_BEACON_IMAGE_ENTRYPOINT = ["nimbus_beacon_node"]
Expand Down Expand Up @@ -149,6 +149,13 @@ def launch(
participant_log_level, global_log_level, NIMBUS_LOG_LEVELS
)

# Holesky has a bigger memory footprint, so it needs more memory
if launcher.network == "holesky":
holesky_beacon_memory_limit = 4096
bn_max_mem = (
int(bn_max_mem) if int(bn_max_mem) > 0 else holesky_beacon_memory_limit
)

bn_min_cpu = int(bn_min_cpu) if int(bn_min_cpu) > 0 else BEACON_MIN_CPU
bn_max_cpu = int(bn_max_cpu) if int(bn_max_cpu) > 0 else BEACON_MAX_CPU
bn_min_mem = int(bn_min_mem) if int(bn_min_mem) > 0 else BEACON_MIN_MEMORY
Expand Down