Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add methods for configuring record metadata #138

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

shagren
Copy link
Contributor

@shagren shagren commented Aug 5, 2021

For PyK4ARecord added new methods which allow to configure mkv metadata: add_tag() and add_attachment()

Now you can create record based on existing record i.e. for filtration and dropping some frames. See test_transfering_calibration()

@shagren
Copy link
Contributor Author

shagren commented Aug 5, 2021

CC: @lpasselin

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

❗ No coverage uploaded for pull request base (develop@0940fa8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #138   +/-   ##
==========================================
  Coverage           ?   81.43%           
==========================================
  Files              ?       12           
  Lines              ?      781           
  Branches           ?        0           
==========================================
  Hits               ?      636           
  Misses             ?      145           
  Partials           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0940fa8...7a487b9. Read the comment docs.

@shagren shagren changed the title Add methods for configuring record metadata WIP: Add methods for configuring record metadata Aug 5, 2021
@shagren
Copy link
Contributor Author

shagren commented Aug 5, 2021

Like as not fully ready :(

@lpasselin
Copy link
Collaborator

I'll be afk in the woods for the next 2 weeks so will not be able to review.
Feel free to merge when you think it is ready if you don't want to wait for me. You have the maintainer power.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants