-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/body tracking #96
base: feature/body-tracking
Are you sure you want to change the base?
Feature/body tracking #96
Conversation
035b782
to
55760ee
Compare
@@ -29,7 +29,7 @@ class pyk4a_build_ext(build_ext): | |||
boolean_options = build_ext.boolean_options + ['enable-body-tracking', ] | |||
|
|||
def initialize_options(self): | |||
self.enable_body_tracking = False | |||
self.enable_body_tracking = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plan was to merge the body tracking branch into the master branch someday.
I worry we will forget to reset this to False before the merge.
pyk4a/pyk4a.cpp
Outdated
@@ -1254,6 +1255,12 @@ extern "C" { | |||
free(buffer); | |||
} | |||
|
|||
static void capsule_cleanup_body_ids(PyObject *capsule) { | |||
fprintf(stdout, "free called on body ids"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fprintf
should be removed after you confirm it is called properly
Hi and thanks for the PR! I always assumed body_id was simply an index. It is sad the Do you think we should save the capsule usage by replacing the body_id numpy array with a It's just an idea, let me know if you think it would be faster this way. |
Any ideas when this will make it to master? |
It's not my top priority right now. |
Yup. I needed the body tracking sdk for python. I'm trying to build something on top of it which will run on linux, hence needed this capability. |
@lpasselin please find some time to work on it, I also need this capability, currently using @nathantsoi 's branch |
Yep, I also need this haha. |
It would be great to have body tracking in the master! |
In my testing, I've found that cleanup functions
How to reproduce: I don't really know why is that happening but it causes huge memory leaks (~14 MB/s if Edit: |
fix memory leaks in body tracking
2 changes in this branch / pr: