Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oceans not covered #34

Closed
flohoff opened this issue Feb 28, 2018 · 6 comments
Closed

Oceans not covered #34

flohoff opened this issue Feb 28, 2018 · 6 comments

Comments

@flohoff
Copy link

flohoff commented Feb 28, 2018

Hi,
is there a way to merge with timezones on water? Die Oceans are covered with timezone stripes aswell and i'd need them.

Flo

@evansiroky
Copy link
Owner

Oceans are currently not included, but I've had enough requests for them that I think I'll try to add them to the next release.

@zedxxx
Copy link

zedxxx commented Mar 8, 2018

to the next release

@evansiroky Will it be soon?

@evansiroky
Copy link
Owner

I can't make any promises on how soon I'll get around to it. Also, there hasn't been a new release from the timezone database, so a new release from this project isn't something urgent or imminent right now.

In the meantime, I'm open to receiving pull requests to implement this feature if anybody is motivated.

@evansiroky
Copy link
Owner

Implemented in 2632584

@zedxxx
Copy link

zedxxx commented Apr 13, 2018

I'm confused. I thought that ocean time zones should be like this: https://commons.wikimedia.org/wiki/File:Standard_World_Time_Zones.png

i.e., they should be a little more complicated than just +1 hour for every 15 degrees. Am I wrong?

@evansiroky
Copy link
Owner

Two sources ((1) and (2)) both state only the rule about every 15 degrees of longitude. The other maps that have more nuance are mainly for illustrative purposes. I've wrote a little bit about this in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants