Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit avoids the hardcoded use of the ./dist directory in the diff
anaysis step, instead using the directory specified via a new
--working_dir flag. Without this, the ./dist directory is always used
(if it exists, otherwise failure).
The "dist/dist/" repeat has also been removed because it should no
longer be required.
This commit could have used the
distDir
variable instead, but a new"working_dir" flag has been introduced instead. A generic name has been
chosen to enable its use for things besides diff analysis later if
needed. It's possible that several files in "dist" could be moved there
later if they're not needed in the distribution, but this has not been
attempted here.
I feel a new directory is reasonable because the files associated with
the previous release don't naturally fit with "downloads" (i.e. files
from OSM) or "dist" (the new distribution). In Android in the future, we
may commit dist + download for change history, but committing the
previous release file seems redundant as it also lives in dist/ under a
previous commit.
The flags documentation has been adjusted to try to make the
distinctions between directories clearer.