Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tariff/octopusenergy: Document API Key mode #509

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

duckfullstop
Copy link
Contributor

This PR documents the forthcoming API Key functionality in evcc. Depends on evcc-io/evcc#11555

Needs a German translation from the English (I can just get about translating DE -> EN, but the other way makes my brain hurt!

@naltatis
Copy link
Member

naltatis commented Jan 8, 2024

I've added German translation (for the few UK citizens, that prefer reading German docs 😅)

@duckfullstop
Copy link
Contributor Author

Thank you! Should be good to go just as soon as the feature is 🥳

@duckfullstop duckfullstop marked this pull request as ready for review January 20, 2024 15:43
@duckfullstop
Copy link
Contributor Author

Main branch is ready for review so this can be merged as soon as that is 🎉

@naltatis naltatis marked this pull request as draft March 4, 2024 09:43
@naltatis
Copy link
Member

naltatis commented Mar 4, 2024

Converting this to draft until the related pr in core is done.

@duckfullstop
Copy link
Contributor Author

Ready for merge alongside evcc-io/evcc#11555 pending German translation (@naltatis 🥺)

@duckfullstop
Copy link
Contributor Author

Any chance of a merge on this before people get confused by the deprecation warning?

@naltatis
Copy link
Member

@duckfullstop sorry for the late resonse. I've missed your last messages and just saw it while revisiting the PRs. In the meantime we've introduced template-based tariffs https://docs.evcc.io/en/docs/devices/tariffs
I guess this is the place where most of the explaination from this PR should move to. These sections are autogenerated by the main project and therefore guaranteed to be in sync with releases.

https://github.com/evcc-io/evcc/blob/master/templates/definition/tariff/octopus-productcode.yaml
https://github.com/evcc-io/evcc/blob/master/templates/definition/tariff/octopus-api.yaml

I'll remove (or at least visually deprecate) the tariff section in the evcc.yaml reference area. Can you port the changes from this PR into the main repo templates?

@naltatis naltatis removed the waiting for release Documents a yet unreleased feature label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants