Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huawei Sun2000: consolidate templates #16949

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Huawei Sun2000: consolidate templates #16949

merged 3 commits into from
Oct 31, 2024

Conversation

andig
Copy link
Member

@andig andig commented Oct 29, 2024

Replace #16939

@andig andig added the devices Specific device support label Oct 29, 2024
@andig
Copy link
Member Author

andig commented Oct 29, 2024

@efdece jetzt stimmt aber noch der Name nicht, oder?

SUN2000 with SDongle & Power Sensor

Sind die Änderungen der Datentypen notwendig?

@andig andig marked this pull request as draft October 29, 2024 11:01
@efdece
Copy link

efdece commented Oct 29, 2024

@andig
Danke fürs Zusammenlegen.

  1. Datentypen: Gute Frage. Ich kenne die Internas von EVCC nicht, aber die *nan" sorgen ja für einen entsprechende Info, wenn es keinen gültigen Wert gibt. Evtl. kann jemand da mehr Details zu beisteuern.
  2. Namen: Stimmt, das Dongle ist bei nativ RS485 nicht vorhanden. Wie wäre es einfach mit "huawei-sun2000-powersensor"?
    Dann frage ich mich auch gleich was das einfache Template "huawei-sun2000-dongle" dann noch macht? Ist das damit auch gleich erledigt? Ok, da ist ein Register anders, aber die Beschreibung in "huawei-sun2000-dongle-powersensor" ist da etwas irreführend, finde ich:
    address: 32064 # Input power DC (if no battery in your system - for more precise readings use 32080 # Active generation power AC)

@RTTTC
Copy link
Contributor

RTTTC commented Oct 29, 2024

I think it would be a good idea to separate templates for systems with and without batteries, due to this:

(power)
address: 32064 # Input power DC (if no battery in your system - for more precise readings use 32080 # Active generation power AC)

And use the appropriate register for each.

@andig
Copy link
Member Author

andig commented Oct 29, 2024

Datentypen

Hab ich raus geworfen. Wir wollen hier inhaltlich nichts ändern.

Wie wäre es einfach mit "huawei-sun2000-powersensor"?

Wofür brauchts den Sensor denn eigentlich- nur bei Batterie?

@RTTTC
Copy link
Contributor

RTTTC commented Oct 29, 2024

Powersensor = grid meter, it is a MUST for battery, and also provides consumption data etc for systems without battery.

@andig andig marked this pull request as ready for review October 31, 2024 11:20
@andig andig merged commit 749e7e2 into master Oct 31, 2024
6 checks passed
@andig andig deleted the fix/huawei branch October 31, 2024 11:20
@dMopp
Copy link

dMopp commented Nov 10, 2024

Whats the difference between SUN2000 and SUN2000 (SDongle) ? (From the Documentation)

@efdece
Copy link

efdece commented Nov 11, 2024

@dMopp SUN2000 (SDongle) is without battery. Ok, maybe the name is not obvious enough.

@dMopp
Copy link

dMopp commented Nov 11, 2024

@dMopp SUN2000 (SDongle) is without battery. Ok, maybe the name is not obvious enough.

Not for me, at least :D

Because I can use Sun2000 for SDongle es well and don’t configure a battery at all, that’s why I can’t get the difference ?!

@efdece
Copy link

efdece commented Nov 12, 2024

@dMopp You're absolutely right. Maybe we can consolidate a bit more? Can anyone think of a reason not to?

@VolkerK62
Copy link
Contributor

ref #17212
is this change a breaking change?

@efdece
Copy link

efdece commented Nov 12, 2024

@VolkerK62 from my point of view, no. My setup is working as before. Only changed template name in yaml file.
Maybe info stored in sqlite db is not working with this consolidation? How can the settings be corrected there or is it necessary to delete the db file? Should we continue the discussion in #17212?

@VolkerK62
Copy link
Contributor

@efdece I do not have this hardware. So it would be nice, if you could help in #17212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devices Specific device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants