Make utils.local_import check INSTALLED_APPS for compound paths #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Checks all possible iterations of app name against `INSTALLED_APPS`, so `app.sub_app.module.Class` checks `INSTALLED_APPS` for `app.sub_app.module`, then `app.sub_app`, then `app`, instead of just checking for `app`. - Adds test to characterize new import behavior. - Fixes issue evenicoulddoit#13
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 325 329 +4
=====================================
+ Hits 325 329 +4
Continue to review full report at Codecov.
|
|
Changes look good and the test is beaut. Thanks! I don't know what you're using extensions for, but I'd really love to get your input on #7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks all possible iterations of app name against
INSTALLED_APPS, soapp.sub_app.module.ClasschecksINSTALLED_APPSforapp.sub_app.module, thenapp.sub_app, thenapp, instead of just checking forapp.Adds test to characterize new import behavior.
Fixes issue util.import_local fails on apps with compound paths #13