Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit decoding of README from UTF-8 in setup.py. #15

Merged
merged 2 commits into from
Dec 21, 2017

Conversation

KyeRussell
Copy link
Contributor

This fixes an issue I have installing this page using Python 3.5 and without (py)pandoc.

    Traceback (most recent call last):
      File "/tmp/pip-9otzkogk-build/setup.py", line 60, in get_long_description
        import pypandoc
    ImportError: No module named 'pypandoc'
    
    During handling of the above exception, another exception occurred:
    
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-9otzkogk-build/setup.py", line 88, in <module>
        long_description=get_long_description(),
      File "/tmp/pip-9otzkogk-build/setup.py", line 62, in get_long_description
        return open('README.md').read()
      File "/usr/lib/python3.5/encodings/ascii.py", line 26, in decode
        return codecs.ascii_decode(input, self.errors)[0]
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 3631: ordinal not in range(128)

@codecov-io
Copy link

codecov-io commented Dec 13, 2017

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #15    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files           5      3     -2     
  Lines         329    126   -203     
======================================
- Hits          329    126   -203
Impacted Files Coverage Δ
...est_framework_serializer_extensions/serializers.py
rest_framework_serializer_extensions/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43c5d75...cc11e31. Read the comment docs.

@evenicoulddoit
Copy link
Owner

@KyeRussell awesome, thanks for this. Noticed the signature difference between Py2 and Py3, but then saw that you'd addressed that, so nice. Could this be a problem in Python 2 or is the encoding assumed to be utf8?

@KyeRussell
Copy link
Contributor Author

KyeRussell commented Dec 13, 2017 via email

@evenicoulddoit evenicoulddoit merged commit e63a9b0 into evenicoulddoit:master Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants