Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: module not found "https://deno.land/std/hash/mod.ts". #364

Merged
merged 1 commit into from
Oct 28, 2022
Merged

fix: module not found "https://deno.land/std/hash/mod.ts". #364

merged 1 commit into from
Oct 28, 2022

Conversation

firleaf
Copy link
Contributor

@firleaf firleaf commented Oct 28, 2022

This fixes a dependency issue which prevented the installation of denodb.

Version 2.10.1 of the mysql driver used god_crypto as a dependency which relied on the deprecated and now removed deno std/hash. Version 2.10.3 of the mysql driver ditches this dependency in favour of SubtleCrypto.

This should not break anything, as it is only a patch level update.
Tested with MariaDB using the MySQLConnector.

@eveningkid
Copy link
Owner

Thanks a lot for this change and bringing all that context to review :)

Let's merge, have a great weekend!

@eveningkid eveningkid merged commit 3a384bb into eveningkid:master Oct 28, 2022
@firleaf firleaf deleted the denodb-pr-mysql_dependency_fix branch October 28, 2022 18:05
@Tandashi
Copy link

Tandashi commented Nov 1, 2022

Any ideas when this will be release?

@Tandashi Tandashi mentioned this pull request Nov 1, 2022
@rojvv
Copy link

rojvv commented Nov 3, 2022

@eveningkid We need a tag, but take your time!

@eveningkid
Copy link
Owner

Thanks for the reminder @roj1512!

I actually just added a github action so that it automatically creates a new release upon pushes to master

Hopefully we won't ever face this situation again :)

Thanks again for pinging me Roj, and @Tandashi you can now use this change with v1.1.0!

Enjoy the rest of your week!

@rojvv
Copy link

rojvv commented Nov 4, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants