Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Failures on Node v10 & v11 #43

Closed
kwelch opened this issue Oct 25, 2018 · 2 comments · Fixed by #51
Closed

Build Failures on Node v10 & v11 #43

kwelch opened this issue Oct 25, 2018 · 2 comments · Fixed by #51
Labels
released

Comments

@kwelch
Copy link
Contributor

kwelch commented Oct 25, 2018

Current Behavior

Currently, travis is failing for all builds on the node host since the latest release (11) came out.

Expected Behavior

Build is failing.

Possible Solution

Upgrade gulp and related packages

Steps to Reproduce (for bugs)

  • nvm use 11
  • yarn
  • yarn build
    Note: this errors out but slightly in a different way than travis. mainly due to scripts failing during the install failing. However you get another error in the build references how the modules were build on a different node version.

Screenshots (if appropriate):

Your Environment

  • SDK version: 1.0.2
  • Node version: v11.0.0
  • Browser name and version: N/A
  • Operating system: OSX
@kwelch-eb kwelch-eb mentioned this issue Oct 25, 2018
Merged
4 tasks
@kwelch-eb
Copy link
Contributor

kwelch-eb commented Dec 27, 2018 •
edited
Loading

We have another build failure with this same error. However this time it is on node@10.

I was able to reproduce locally.

Error Stack 

$ gulp build
internal/util/inspect.js:31
const types = internalBinding('types');
              ^
ReferenceError: internalBinding is not defined
    at internal/util/inspect.js:31:15
    at req_ (/home/travis/build/eventbrite/eventbrite-sdk-javascript/node_modules/natives/index.js:137:5)
    at require (/home/travis/build/eventbrite/eventbrite-sdk-javascript/node_modules/natives/index.js:110:12)
    at util.js:25:21
    at req_ (/home/travis/build/eventbrite/eventbrite-sdk-javascript/node_modules/natives/index.js:137:5)
    at require (/home/travis/build/eventbrite/eventbrite-sdk-javascript/node_modules/natives/index.js:110:12)
    at fs.js:42:21
    at req_ (/home/travis/build/eventbrite/eventbrite-sdk-javascript/node_modules/natives/index.js:137:5)
    at Object.req [as require] (/home/travis/build/eventbrite/eventbrite-sdk-javascript/node_modules/natives/index.js:54:10)
    at Object.<anonymous> (/home/travis/build/eventbrite/eventbrite-sdk-javascript/node_modules/vinyl-fs/node_modules/graceful-fs/fs.js:1:99)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: "build:targets" exited with 1.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
The command "yarn run build" exited with 1.

@kwelch-eb kwelch-eb changed the title Update package to build on node@11 Build Failures on Node v10 & v11 Dec 27, 2018
@kwelch kwelch mentioned this issue Dec 27, 2018
Merged
4 tasks
kwelch-eb pushed a commit that referenced this issue Dec 28, 2018
@kwelch @kwelch-eb
fix(build): Update dependencies and build pipeline (#51)
8afff6d 
<!--- Provide a general summary of your changes in the Title above -->

## Description
Updated all dependencies to fix error in build pipeline. 

fixes #43 
<!--- Describe your changes in detail -->

<!--- Please include the phrase "BREAKING CHANGE:" here if your require a major release -->

<!--- Don't forget to note any issues here with "fixes #<issue number>" -->

## How Has This Been Tested?
Locally, I have used node v10 to build the project. Travis will also run all check against all supported versions. 

I plan to also check against node v 11 and re-enable it in the build jobs. 

<!--- Please describe in detail how you tested your changes. -->

<!--- For bug fixes, include regression unit tests that fail without the fix -->

<!--- For new features, include unit tests for the new functionality -->

## Screenshots (if appropriate):

## Checklist:

<!--- Please mark an `x` in all the boxes that apply. -->

<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

*   [x] I have read the [**CONTRIBUTING** document](https://github.com/eventbrite/eventbrite-sdk-javascript/blob/master/CONTRIBUTING.md).
*   [ ] I have updated the documentation accordingly.
*   [x] I have added tests to cover my changes.
*   [x] I have run `yarn validate` to ensure that tests, typescript and linting are all in order.
@ebtravis
Copy link
Collaborator

🎉 This issue has been resolved in version 1.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): Update dependencies and build pipeline kwelch/eventbrite-sdk-javascript
3 participants
@kwelch @kwelch-eb @ebtravis