Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token should be moved to authorization header #9

Closed
benmvp opened this issue Feb 28, 2018 · 1 comment
Closed

Token should be moved to authorization header #9

benmvp opened this issue Feb 28, 2018 · 1 comment
Assignees
@benmvp
Milestone
Alpha

Comments

@benmvp
Copy link
Contributor

benmvp commented Feb 28, 2018

With #8, we pass the authentication token as a query parameter in API requests. Based on the authentication docs, the preferred approach is to pass the token in the Authorization header:

Authorization: Bearer MY_TOKEN

Fixing this will also have the added benefit of removing the dependency on url-lib
This was referenced Feb 28, 2018
Merged
Merged
BenAtEventbrite pushed a commit that referenced this issue Mar 2, 2018
@benmvp @BenAtEventbrite
fix(request): Move API token to Authorization header (#10)
ed8df35 
The [v3 API Authentication docs](https://www.eventbrite.com/developer/v3/api_overview/authentication/#ebapi-authenticating-requests) indicate that the preferred approach for authenticating requests is to pass the OAuth token in the `Authorization` header instead of as a query parameter, so this makes that change.

Also adds `prefer-const` ESLint rule since `eslint-config-evenbrite` doesn't yet have it defined.

Fixes #9
@BenAtEventbrite BenAtEventbrite added this to the Alpha milestone Apr 5, 2018
@ebtravis
Copy link
Collaborator

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benmvp benmvp

Labels
None yet
Projects
None yet
Milestone
Alpha
Development

No branches or pull requests
3 participants
@benmvp @BenAtEventbrite @ebtravis