chore(build): Fix build in Node 10 by updating yarn.lock #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwelch-eb
approved these changes
May 3, 2018
4 tasks
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build was breaking on
'node'version in Travis because'node'now points to new v10 that that was released. One of gulp's dependencies didn't work correctly with it. See: gulpjs/gulp#2162 (comment).The fix was to
yarn remove gulp gulp-debugandyarn add --dev gulp gulp-debug. This bumpedgulp-debugto a new version, but the main fix was the updates toyarn.lockto use new versions of packages specifically[email protected].How Has This Been Tested?
I upgraded to node@10 locally and tried to run
yarn run validate. It failed until I made the updates toyarn.lock.Checklist:
yarn validateto ensure that tests, typescript and linting are all in order.