Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(request): Fix request() w/ relevant docs #36

Merged
merged 5 commits into from
May 17, 2018
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions docs/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
# Eventbrite JavaScript SDK Documentation

This SDK interface closely mirors the [Eventbrite v3 REST API](https://www.eventbrite.com/developer/v3/) endpoints that it wraps. The SDK provides many conveniences for making requests and processing responses to make it easier to use in the JavaScript environment.

## ToC

* [Including the package](#including-the-package)
* [Configuring a SDK object](#configuring-a-sdk-object)
* [`request()`](./request)

## Including the package

First include the `eventbrite` package (depending on your module environment):

### Webpack / Rollup / etc ([ECMAScript modules](https://unpkg.com/eventbrite/lib/esm/)):

```js
import eventbrite from 'eventbrite';
```

### Node / legacy dependency systems ([CommonJS](https://unpkg.com/eventbrite/lib/cjs/) / [Universal Module Definition](https://unpkg.com/eventbrite/lib/umd/)):

```js
const eventbrite = require('eventbrite');
```

### `<script>` [distribution bundle](https://unpkg.com/eventbrite/dist/) include:

```
<script src="https://unpkg.com/eventbrite/dist/eventbrite.min.js"></script>
```

NOTE: `window.Eventbrite` will be a reference to the package.

## Configuring a SDK object

In order to make requests, we need to configure the SDK object.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: might change the 'we' to 'you' since you use 'you' in later sentences

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch


```js
import eventbrite from 'eventbrite';

// Create configured Eventbrite SDK
const sdk = eventbrite({token: 'OATH_TOKEN_HERE'});
```

You can configure the SDK object with the following properties:

* `token` - The Eventbrite [OAuth token](https://www.eventbrite.com/developer/v3/api_overview/authentication/#ebapi-getting-a-token)
* `baseUrl` - The base URL prepending to endpoints when making API requests (defaults to `'https://www.eventbriteapi.com/v3'`). So when using the `'/users/me/'` endpoint, a request would be made to `https://www.eventbriteapi.com/v3/users/me/`. _NOTE: You probably will not need to use this property._

From then on, you can use `sdk` to make API requests.
156 changes: 156 additions & 0 deletions docs/request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,156 @@
# `request()`

`request()` is the Promise-based, low-level function for making [`fetch`](https://github.com/matthew-andrews/isomorphic-fetch) requests to the Eventbrite v3 REST API, returning responses as JSON. The higher-level convenience endpoint functions use `request()` under the hood for making their requests. We suggest that you use the convenience endpoint functions over `request()`. But there may be cases where new or updated endpoints exist withing the REST API, and the SDK has not yet been updated to provide convenience functions.

`request()` provides additional request and response handling over `fetch`.

For requests it:

* Prepends a configurable base URL to the endpoint you specify (see [Configuring a SDK object](./#configuring-a-sdk-object))
* Adds your [OAuth token](https://www.eventbrite.com/developer/v3/api_overview/authentication/#ebapi-getting-a-token) in the request `Authorization` header
* Sets the appropriate `Content-type` header depending on the `fetch` `method` (`GET`, `POST`, etc.) configuration you use
* Sets the appropriate `credentials` setting depending on the `fetch` `mode` (`cors`, etc.) configuration you use

For responses it:

* Returns a resolved `Promise` with the response data parsed as JSON
* If the HTTP status is in the 400 or 500 range, returns a rejected `Promise` with parsed API errors, [if applicable](#error-handling)

## API

The TypeScript function definition of `request()` is:

```
(endpoint: string, options?: RequestInit): Promise<{}>
```

### Parameters

`request()` accepts the following parameters:

* `endpoint`: The Eventbrite v3 API endpoint path, such as `/users/me/`. This will be appended to the `baseUrl` defined when [configuring the SDK object](./#configuring-a-sdk-object).
* `options`: The request initialization options that [`fetch()`](https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/fetch) accepts. Your [OAuth token](https://www.eventbrite.com/developer/v3/api_overview/authentication/#ebapi-getting-a-token) will be added to the request `Authorization` header for you. Some additional options you may need to pass in are:
* `options.method`: The [HTTP method](https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods) (e.g. `GET`, `POST`, etc.) for the fetch. Non-`GET` requests add `application/json` as `Content-Type` by default.
* `options.mode`: The request mode (e.g. `cors`, `same-origin`, etc.) for the fetch. Defaults the `credentials` option to `include` when `mode` is `cors`. Otherwise the `credentials` default to `same-origin`.

### Response

The return value from `request()` is a [`Promise`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Using_promises) that contains the response from the API call. If the response is successful, the response data will be parsed as JSON.

See the [Error Handling](#error-handling) section for more information on the default error handling that `request()` provides.

## Examples

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about giving a quick shoutout to the fact that you can use this sdk on the client or on the server? Not sure where it would live.. is it just assumed that libraries are using isomorphic fetch these days?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll do this in #33 where the main README is getting updated. Think this is a good idea


The simplest approach is to use ES2015 Promises:

```js
const eventbrite = require('eventbrite');

// Create configured Eventbrite SDK
const sdk = eventbrite({token: 'OATH_TOKEN_HERE'});

// See: https://www.eventbrite.com/developer/v3/endpoints/users/#ebapi-get-users-id
sdk.request('/users/me').then(user => {
console.log(`Hi ${user.name}!`);
});
```

## Error Handling

To make interacting with the Eventbrite API easier, the SDK handles and parses some additional errors by default.

When an error occurs during an API request, the Eventbrite v3 API will send a response with an error HTTP status (in the 400 or 500 range), as well as a JSON response containing more information about the error:

```json
{
"status_code": 404,
"error_description": "The user you requested does not exist.",
"error": "NOT_FOUND"
}
```

The SDK recognizes that an error has occurred (by inspecting the HTTP status code) and returns a **rejected** promise with an object that contains the errored response as the `response` property and error information in the `parsedError` property. This way you can easily distinguish whether or not your API request succeeded or failed:

```js
const eventbrite = require('eventbrite');

// Create configured Eventbrite SDK
const sdk = eventbrite({token: 'OATH_TOKEN_HERE'});

// BAD User ID
const userId = '123456789';

// See: https://www.eventbrite.com/developer/v3/endpoints/users/#ebapi-get-users-id
sdk
.request(`/users/${userId}`)
.then(user => {
// Successful response
console.log(`Hi ${user.name}!`);
})
.catch(errInfo => {
// An error occurred
// Original error response is passed in `response` property
console.error(errInfo.response['error_description']);

// `ARGUMENT_ERROR` errors are parsed into `parsedError` property
const parsedError = errorInfo.parsedError;

// equivalent to errorInfo.response.error
console.log(parsedError.error);

// equivalent to errorInfo.response['error_desscripion']
console.log(parsedError.description);
});
```

Read more about [Errors](https://www.eventbrite.com/developer/v3/api_overview/errors/) within the Eventbrite v3 API.

One of the [Common Errors](https://www.eventbrite.com/developer/v3/api_overview/errors/#ebapi-common-errors) in the Eventbrite v3 API, is the `ARGUMENTS_ERROR` error (returned with `400` HTTP code). This happens when one of the parameters passed to the API call is invalid. You would get a response like:

```json
{
"status_code": 400,
"error_detail": {
"ARGUMENTS_ERROR": {
"status": ["INVALID"]
}
},
"error_description":
"There are errors with your arguments: status - INVALID",
"error": "ARGUMENTS_ERROR"
}
```

It includes an `error_detail` property that contains additional data about the offending parameters. The SDK parses the `ARGUMENT_ERROR` data within `error_detail` adding it to the `parsedError` property in the rejected promise as the `argumentErrors` property:

```js
const eventbrite = require('eventbrite');

// Create configured Eventbrite SDK
const sdk = eventbrite({token: 'OATH_TOKEN_HERE'});

// See: https://www.eventbrite.com/developer/v3/endpoints/users/#ebapi-get-users-id-events
sdk
.request('/users/me/events?status=blah')
.then(user => {
// Successful response
console.log(`Hi ${user.name}!`);
})
.catch(errInfo => {
// An error occurred
// Original error response is passed in `response` property
console.error(errInfo.response['error_description']);

// `ARGUMENT_ERROR` errors are parsed into `parsedError` property
const parsedError = errorInfo.parsedError;

// equivalent to errorInfo.response['error_detail']['ARGUMENT_ERROR']
console.log(parsedError.argumentErrors);

// equivalent to errorInfo.response.error (would be "ARGUMENT_ERROR")
console.log(parsedError.error);

// equivalent to errorInfo.response['error_desscripion']
console.log(parsedError.description);
});
```
Loading