Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): remove babel plugin for external helpers #40

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

jcreamer898
Copy link
Contributor

Should fix issue with babel helpers in client libs.

@kwelch-eb kwelch-eb requested a review from rwholey-eb July 10, 2018 13:21
@kwelch-eb
Copy link
Contributor

So they even call out that:

This may become an issue if you have multiple files, especially when you're sending them to the browser. gzip alleviates most of this concern but it's still not ideal.

They recommend building and injecting the helpers.
https://babeljs.io/docs/en/babel-plugin-external-helpers.html#getting-the-external-helpers

Copy link
Contributor

@kwelch-eb kwelch-eb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could leverage this, but include them properly. Is there a way we can test this before building and deploying a new version.

@jcreamer898
Copy link
Contributor Author

Personally I think it's overkill to worry about the overhead of including external helpers. The helpers that they inject are small enough that it's a bit of a micro-optimization.

@jonathancreamer-eb jonathancreamer-eb merged commit fe3cc95 into eventbrite:master Jul 10, 2018
@ebtravis
Copy link
Collaborator

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jcreamer898 jcreamer898 deleted the jc-plugin-remove branch July 10, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants