Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deploy): Update deploy to use LTS node host #44

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

kwelch
Copy link
Contributor

@kwelch kwelch commented Oct 31, 2018

Description

After disabling the node host due to a build error, the release was not deployed since it was set to run on the node host.

Going forward we are going to use the node LTS as our deploy host.

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • I have read the CONTRIBUTING document.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have run yarn validate to ensure that tests, typescript and linting are all in order.

@kwelch-eb kwelch-eb merged commit 41e257a into eventbrite:master Oct 31, 2018
Copy link
Contributor

@benmvp benmvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kwelch kwelch deleted the kwelch-update-deploy branch November 1, 2018 13:55
@ebtravis
Copy link
Collaborator

ebtravis commented Nov 6, 2018

🎉 This PR is included in version 1.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants