Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(users): Add users collection to SDK #52
feat(users): Add users collection to SDK #52
Changes from 6 commits
3f3c501
89530c7
174d8b8
3f2d2d7
6026411
698b878
ab23e91
a3fd6e1
3c16eaa
5288f3f
a1f11d4
57a0e5c
22b978b
90b597a
c232d53
24aae2b
926c305
ac627ec
a71616a
ab65a28
f1e5574
fcdb247
28437e5
e05a3b2
dfca786
392ac6d
9b6dabb
95c2b15
54dd2b3
2cb171e
817fa36
7afe721
2a8c562
1170cc6
4c18869
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you wanna use a lib like
camelize
? https://yarnpkg.com/en/package/camelize. Cuz now in theory we need tests fortransformKeysSnakeToCamel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will look into a package, however that one will not work because it also converts dotCase to camel, which breaks our API. That is what led us to making this function internally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is turning out to be difficult to find something for since it is very generic, but all of them convert
expand.destination_event
toexpandDestinationEvent
, which is undesired.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about leaving this and adding tests? It is that or I make a package of it 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this around and added tests. Also working on adding something to camel-keys to allow us to be able to remove this.