Fixed types for TS 3.6.2

[danielepolencic]

The library doesn't work with recent versions of TS.
See #62

How Has This Been Tested?

npx tsc --noEmit

Checklist:

• I have read the CONTRIBUTING document.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• I have run yarn validate to ensure that tests, typescript and linting are all in order.

[kwelch]

Would it be better to do [key: string]?: ?

[danielepolencic]

I tried and it wasn't happy about it

node_modules/eventbrite/lib/types.d.ts:39:18 - error TS1005: ';' expected.

39     [key: string]?: T[] | Pagination;
                    ~

node_modules/eventbrite/lib/types.d.ts:39:19 - error TS1131: Property or signature expected.

39     [key: string]?: T[] | Pagination;
                     ~

node_modules/eventbrite/lib/types.d.ts:39:21 - error TS1131: Property or signature expected.

39     [key: string]?: T[] | Pagination;
                       ~

node_modules/eventbrite/lib/types.d.ts:39:23 - error TS1011: An element access expression should take an argument.

39     [key: string]?: T[] | Pagination;
                         

node_modules/eventbrite/lib/types.d.ts:40:1 - error TS1128: Declaration or statement expected.

40 }
   ~

[benmvp]

Sorry for chiming in so later on this. I don't think you can make a property indexer optional, as @danielepolencic already showed.

My question is why is it:

[key: string] T[] | Pagination

Why the | Pagination? Why would it be a Pagination. Can it just be:

export interface PaginatedResponse<T> {
    pagination: Pagination;
    [key: string]: T[];
}

Will that fix it by removing the ambiguity?

[danielepolencic]

node_modules/eventbrite/lib/types.d.ts:38:5 - error TS2411: Property 'pagination' of type 'Pagination' is not assignable to string index type 'T[]'.

38     pagination: Pagination;
       ~~~~~~~~~~

It doesn't work.

[kwelch]

@benmvp or @jcreamer898 Do either of you have thoughts on this? I don't see any issues with it, but I know little TS.

[kwelch-eb]

Thanks for the PR!

[ebtravis]

🎉 This PR is included in version 1.2.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀