Marionette views order #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagoar
reviewed
Sep 28, 2016
| - **Outside** `Marionette.View` definition | ||
|
|
||
| 0. `dependencies` requirement | ||
| 0. `static` methods |
There was a problem hiding this comment.
functions istead of methods
| 0. `static` methods | ||
| 0. `config` objects | ||
|
|
||
| - Ordering for `Marionette.View`: |
There was a problem hiding this comment.
you could say first life cycle methods as a clarification (so it doesn't need to be by extension and it can be by comprehension )
There was a problem hiding this comment.
I'm not sure if I'm following you. Even referencing only the life cycle methods, I've received a specific order when it comes to ordering these methods. While I'm not proposing a strict order I think there is an implicit order anyway.
There was a problem hiding this comment.
what you did is OK. I was suggesting adding between (and the remaining life cycle methods) so we don't have to mention every method. only the ones we care about (as you did)
eb-agustin
force-pushed
the
views-ordering
branch
2 times, most recently
from
17f66e1 to
608a500
Compare
eb-agustin
force-pushed
the
views-ordering
branch
from
608a500 to
0a36cd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.