Skip to content
This repository has been archived by the owner on Feb 12, 2019. It is now read-only.

self.instance should not take "commit=True" #2

Open
mwildehahn opened this issue May 1, 2014 · 0 comments
Open

self.instance should not take "commit=True" #2

mwildehahn opened this issue May 1, 2014 · 0 comments

Comments

@mwildehahn
Copy link

https://github.com/eventbrite/rebar/blob/master/src/rebar/group.py#L217

django models don't support "commit=True"

https://github.com/django/django/blob/stable/1.5.x/django/db/models/base.py#L490-L491
mwildehahn pushed a commit that referenced this issue May 1, 2014
Fix for Issue #2: Should not be passing "commit=True" to django model…
e57ec69 
… instance "save" methods

Django model's don't have a "commit" kwarg.
mwildehahn pushed a commit that referenced this issue May 1, 2014
Merge pull request #3 from eventbrite/fix-issue-2
323684c 
Fix for Issue #2: Should not be passing "commit=True" to django model in...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mwildehahn