-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Barcode Scanner App powered by React (via wp packages) (wip) #7
Conversation
- updates webpack to 4 - update webpack config - updates various packages - fix up packages (that I can) which fail npm audit - copy over latest i18n-map-extractor.js from core.
Including: - bootstrap changes - utilizing PHP 5.6 - implementing Domain and getting rid of most global constants - implmenting new asset system.
Components for
|
I'm also going to experiment with using https://github.com/react-tools/react-table as a table component for this mini-app. If it works well, I may make this a recommended table component for the react stuff we do. Along with that, I may use this HOC: https://github.com/dumptruckman/accessible-react-table to ensure our tables are accessible out of the gate. |
this also registers a temporary tab for initial experimenation with the new app (alongside with the old app for reference).
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has been stale for a significant period of time without any activity. |
46fd200
to
0f8e526
Compare
The old names weren’t very clear.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has been stale for a significant period of time without any activity. |
This issue has been automatically closed because it has been stale for a significant period of time without any activity. |
Note: This branch now contains force pushed changes from a branch @tn3rb did some work on. So make sure you delete locally the branch for this pull and grab the latest from github.
Problem this Pull Request solves
As a part of doing #2 (converting
[ESPRESSO_BARCODE_SCANNER]
shortcode to a Gutenberg Block), I decided that it would be prudent to do the first step of creating a React based app for the actual scanner to replace the ajax/js powered existing app rendered via the shortcode. There's a few reasons for this including:Priority wise, the goal of this pull is to get to the app to a functional state replacing the feature set of the current shortcode powered app. This means that everything should work, but it won't be in a releasable state until the ui/ux receives some polish.
What needs done
This is an itemized list of things needing done for this app and what is complete.
NOTE: This pull will contain commits including new components that I'm testing as a part of this work that will eventually be extracted and added to event-espresso-core for the global components. Things that are useful for usage by multiple EE products vs just this add-on.
How has this been tested
Checklist
esc_html__()
, see https://codex.wordpress.org/I18n_for_WordPress_Developers)Components being extracted to ee core (see zenhub dependencies connections for links to related pulls):
<TextBubble />
(components/ui/enhanced-text/text-bubble
)<StatusCircle />
(components/ui/indicators/status-circle
)<StatusSection />
(components/ui/indicators/status-section
)<CheckInAction />
(registration-view/checkin
)<CheckInButton />
(registration-view/checkin
)get-checkin-in-status-configuration
(helpers fromregistration-view/checkin/get-check-in-status-configuration
)<CheckInStatusIcon />
(registration-view/checkin
)withLatestCheckin
( 'registration-view/checkin`)Other important notes: