Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#1019 maximum delivery radius #1286

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

valiopld
Copy link
Contributor

@valiopld valiopld commented Jul 27, 2020

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

#1019
This is the way that i think it should be done on the serverside.
Tomorrow I will set the new feature to the front end and make a video of how it works

@valiopld
Copy link
Contributor Author

valiopld commented Jul 28, 2020

@evereq
https://www.loom.com/share/782938f2b3c346a9aa0baaa81f977621

If "max Delivery Radius" from admin/store/delivery areas/ is not setted -
the default radius is 50 000m - that can be seen at the beginning of the video (2 of the stores are inside the radius of 50km)

not sure what happened again with the commits

@valiopld valiopld requested a review from evereq July 28, 2020 11:47
@valiopld valiopld marked this pull request as ready for review July 28, 2020 11:49
@evereq
Copy link
Member

evereq commented Aug 4, 2020

@valiopld what you mean by "not sure what happened again with the commits"? What is the status of this? What about delivery zones etc? I want to see final video of how all that working when you finish

@CLAassistant
Copy link

CLAassistant commented Feb 1, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ valiopld
❌ evereq
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants