Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

chore(evm): Refactor module params storage to latest Cosmos SDK release #1470

Closed
wants to merge 2 commits into from
Closed

chore(evm): Refactor module params storage to latest Cosmos SDK release #1470

wants to merge 2 commits into from

Conversation

Vvaradinov
Copy link
Contributor

@Vvaradinov Vvaradinov commented Nov 17, 2022 •
edited
Loading

Refer to 1472

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@github-actions github-actions bot added the C:Proto protobuf files (*.pb.go) label Nov 17, 2022
@Vvaradinov Vvaradinov marked this pull request as ready for review November 17, 2022 12:07
@Vvaradinov Vvaradinov requested a review from a team as a code owner November 17, 2022 12:07
@Vvaradinov Vvaradinov requested review from ramacarlucho, GAtom22, alexanderbez and fedekunze and removed request for a team November 17, 2022 12:07
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 17, 2022
View reviewed changes
x/evm/types/msg.go

// GetSigners returns the expected signers for a MsgUpdateParams message.
func (m *MsgUpdateParams) GetSigners() []sdk.AccAddress {
addr, _ := sdk.AccAddressFromBech32(m.Authority)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack.

Returned error is not propagated up the stack.
@Vvaradinov Vvaradinov closed this Nov 17, 2022
@Vvaradinov Vvaradinov deleted the Vvaradinov/refactor-deprecated-emv-params-logic branch November 17, 2022 14:54
@mergify
Copy link
Contributor

mergify bot commented Nov 17, 2022

⚠️ The sha of the head commit of this PR conflicts with #1472. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ramacarlucho ramacarlucho Awaiting requested review from ramacarlucho ramacarlucho is a code owner automatically assigned from evmos/core-engineering

@GAtom22 GAtom22 Awaiting requested review from GAtom22 GAtom22 is a code owner automatically assigned from evmos/core-engineering

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@fedekunze fedekunze Awaiting requested review from fedekunze

Assignees
No one assigned
Labels
C:Proto protobuf files (*.pb.go)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vvaradinov