Skip to content

Commit

Permalink
#333: Added project short tag in notebook tests (#334)
Browse files Browse the repository at this point in the history
* #333: Added project short tag in notebook tests
* Update ca-certificates version

* [CodeBuild]
  • Loading branch information
ckunki authored Oct 24, 2024
1 parent f9aed53 commit 67032c5
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/notebook_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,4 @@ jobs:
NBTEST_AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
NBTEST_AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_ACCESS_KEY_SECRET }}
NBTEST_AWS_DEFAULT_REGION: ${{ secrets.AWS_REGION }}
PROJECT_SHORT_TAG: XAIL-NB
3 changes: 3 additions & 0 deletions doc/changes/changes_3.2.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ Code name:

## Summary

## Refactorings

* #333: Added project short tag in notebook tests

## Bug Fixes

Expand Down
2 changes: 1 addition & 1 deletion doc/developer_guide/updating_packages.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ If the update is very new and not yet displayed on packages.ubuntu.com you can u

```shell
apt-get update
apt-search <package>
apt search <package>
```

Maybe installing the command [chdist](https://manpages.ubuntu.com/manpages/xenial/en/man1/chdist.1.html) could also be helpful, as it allows searching for packages and updates in other versions and distributions of ubuntu than the one installed on your local system.
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ def test_notebook(notebook_test_container_with_log, notebook_test_file, notebook
environ = os.environ.copy()
environ["NBTEST_ACTIVE"] = "TRUE"
nbtest_environ = {key: value for key, value in environ.items() if (
key.startswith("NBTEST_") or key.startswith("SAAS_"))}
key.startswith("NBTEST_")
or key.startswith("SAAS_")
or key == "PROJECT_SHORT_TAG")}
exec_command(
command_run_test,
container,
Expand Down

0 comments on commit 67032c5

Please sign in to comment.