Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup SageMaker credentials for Notebook testing in CI #151

Closed
tkilias opened this issue Jan 31, 2024 · 0 comments · Fixed by #153
Closed

Setup SageMaker credentials for Notebook testing in CI #151

tkilias opened this issue Jan 31, 2024 · 0 comments · Fixed by #153
Assignees
@tkilias
Labels
feature Product feature

Comments

@tkilias
Copy link
Collaborator

tkilias commented Jan 31, 2024

The SageMaker notebooks tests needs credentials for our CI AWS account

  • AWS_ACCESS_KEY_ID
  • AWS_SECRET_ACCESS_KEY
  • AWS_DEFAULT_REGION

Tasks:

  1. Setup as secrets
  2. Assign the secrets to environment variables with prefix NBTEST_ in the CI workflow description
  3. Use them in the nbtest_.py files (the notebook test runner passes them through to the container, where nbtest_.py will run)
@tkilias tkilias added the feature Product feature label Jan 31, 2024
@tkilias tkilias self-assigned this Jan 31, 2024
@tkilias tkilias mentioned this issue Jan 31, 2024
Merged
ahsimb pushed a commit that referenced this issue Jan 31, 2024
@tkilias
#151: Setup SageMaker Credentials for notebook testing in the CI (#153)
0eb07f1 
* Moved test_notebooks_in_dss_docker_image.py and the docker test tooling into their own top-level test directory, such that we can address it independently of the other integration tests.

* Added SageMaker secrets to check_ci.yaml and split it into two jobs one for testing notebooks and one for testing building the ai-lab.

* Fix imports

* Move dss_docker_image from conftest to own module and registered it as plugin in the main conftest

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkilias tkilias

Labels
feature Product feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#151: Setup SageMaker Credentials for notebook testing in the CI exasol/ai-lab
1 participant
@tkilias