Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated test for windows #86

Closed
jakobbraun opened this issue Sep 25, 2020 · 5 comments
Closed

Add automated test for windows #86

jakobbraun opened this issue Sep 25, 2020 · 5 comments
Assignees
Labels
refactoring Code improvement without behavior change

Comments

@jakobbraun
Copy link
Contributor

jakobbraun commented Sep 25, 2020

Situation

Exasol Testcontainers were originally written to be used under Linux. We have people using them under Windows now too, so the automated tests should be run there too.

Acceptance Criteria

  • Additional Windows CI test set up in GHA test matrix
  • Failing tests fixed or unavailable features disabled on Windows
@redcatbear redcatbear added the refactoring Code improvement without behavior change label Nov 30, 2020
@pj-spoelders pj-spoelders self-assigned this Mar 22, 2021
@pj-spoelders
Copy link
Contributor

testcontainers/testcontainers-java#2960 On both travis CI and github the runners are 'windows server 2019' or the 2016 version ..
It does run quite well on Windows 10 pro.
There was one test that needed to be fixed. At the moment I will just 'park' this ticket and come back to it later.

@pj-spoelders
Copy link
Contributor

After a brief discussion, @tkilias suggested looking into dedicated machines (costly) or VMs that allow nested virtualisation.
Linux containers on Windows docker require a VM (which WSL2 is and how docker desktop solves it).
We need to look into self-hosted runners anyway (for our UI automation tests) so this is another project that's probably going to need this. Apparently the 'script language tool' would be another candidate.

@pj-spoelders
Copy link
Contributor

There are also still some errors when I run the extended integration tests so I also need to get back to these.

@pj-spoelders
Copy link
Contributor

@pj-spoelders
Copy link
Contributor

pj-spoelders commented Feb 25, 2022

Current issues:

  • Github actions does not allow/support docker/container operations on windows runners at the moment:
    Support container operations on Windows runners actions/runner#904

  • Other options left would be to use a self hosted runner or azure devops runner. Problems here are:

    • Added maintenance and security risk.
    • You'd need a docker desktop enterprise license for running linux containers (in our case exasol docker-db and others) in a windows environment. Java-testcontainers, the main dependency of exasol-testcontainers, depends on docker for windows/docker desktop on windows.
    • WSL2 depends on a VM for linux containers, which requires virtualisation. Virtualisation is also quite tricky to find and get right (limited support) and expensive to set up in the cloud.
    • WSL1 might bring its own share of issues. Also windows server (which comes only with WSL1) is not supported and there's no real mention of WSL1 in the windows support documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants