Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#174: Upgrade testcontainers dependency (and other dependencies). #175

Merged
merged 8 commits into from
Nov 26, 2021
Merged

#174: Upgrade testcontainers dependency (and other dependencies). #175

merged 8 commits into from
Nov 26, 2021

Conversation

redcatbear
Copy link
Collaborator

Closes #174.

kaklakariada
kaklakariada requested changes Nov 26, 2021
View reviewed changes
Copy link
Collaborator

@kaklakariada kaklakariada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes requested

doc/changes/changes_5.1.2.md Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
src/main/java/com/exasol/containers/ContainerFileOperations.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/containers/ContainerFileOperations.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/containers/ExasolContainerConstants.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/support/SupportInformationRetriever.java Outdated Show resolved Hide resolved
@redcatbear redcatbear self-assigned this Nov 26, 2021
@redcatbear redcatbear added refactoring Code improvement without behavior change source:exasol labels Nov 26, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@redcatbear redcatbear merged commit ddbbc50 into main Nov 26, 2021
@redcatbear redcatbear deleted the refactoring/174-Upgrade_testcontainer branch November 26, 2021 09:13
@redcatbear redcatbear mentioned this pull request Nov 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaklakariada kaklakariada kaklakariada approved these changes

Assignees

@redcatbear redcatbear

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade testcontainers dependency
2 participants
@redcatbear @kaklakariada