#3: added test and documentation for resultSets matcher #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redcatbear
requested changes
May 25, 2020
Comment on lines
72
to
76
| if (!bothRowsExist(actualResultSet, expectedNext, actualNext)) | ||
| return false; | ||
| } | ||
| if (expectedNext && !doesRowMatch(actualResultSet, expectedColumnCount)) { | ||
| this.errorMessage.append(", row ").append(rowCounter).append(")\n"); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
This code makes it very hard to read whether the actual row count will be calculated correctly. The code for that hides in a completely different place: bothRowsExist() calls getRowCounter().
There was a problem hiding this comment.
What can I do to improve it?
redcatbear
approved these changes
May 25, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3