Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature #72: Support aggregate and analytics functions #122

Merged
merged 38 commits into from
Sep 30, 2021
Merged

Feature #72: Support aggregate and analytics functions #122

merged 38 commits into from
Sep 30, 2021

Conversation

kaklakariada
Copy link
Contributor

@kaklakariada kaklakariada commented Sep 23, 2021 •
edited
Loading

Closes #72

  • Add documentation select.md
  • Update list_of_supported_exasol_functions.md
  • Requirement tracing (not necessary)

Refactorings/changes not implemented here:

@kaklakariada kaklakariada self-assigned this Sep 27, 2021
@kaklakariada kaklakariada changed the title Feature/72-support-aggregate-and-analytics-functions Feature #72: Support aggregate and analytics functions Sep 27, 2021
@kaklakariada kaklakariada removed the request for review from jakobbraun September 29, 2021 09:18
jakobbraun
jakobbraun reviewed Sep 29, 2021
View reviewed changes
doc/changes/changes_4.5.0.md Outdated Show resolved Hide resolved
doc/user_guide/statements/select.md Outdated Show resolved Hide resolved
jakobbraun
jakobbraun suggested changes Sep 30, 2021
View reviewed changes
doc/user_guide/statements/select.md Outdated Show resolved Hide resolved
src/main/java/com/exasol/sql/dql/select/rendering/SelectRenderer.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/sql/expression/function/exasol/ExasolAggregateFunction.java
*/
@Deprecated
public enum ExasolAggregateFunction implements FunctionName {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it stil, work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works with the normal ExasolFunction. The AnalyticFunction class requires ExasolAnalyticAggregateFunctions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/main/java/com/exasol/sql/expression/function/exasol/ExasolAggregateFunction.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/sql/expression/function/exasol/ExasolAnalyticFunction.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/sql/expression/function/exasol/ExasolFunction.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/sql/expression/rendering/OverClauseRenderer.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/sql/expression/rendering/OverClauseRenderer.java Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

99.6% 99.6% Coverage
0.0% 0.0% Duplication

@kaklakariada kaklakariada merged commit fd2ca2a into main Sep 30, 2021
@kaklakariada kaklakariada deleted the feature/72-support-aggregate-and-analytics-functions branch September 30, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobbraun jakobbraun jakobbraun approved these changes

Assignees

@kaklakariada kaklakariada

Labels
feature Product feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for unsupported Aggregate and Analytic functions
2 participants
@kaklakariada @jakobbraun