Skip to content

Commit

Permalink
#48: Add JDBC parameter logintype
Browse files Browse the repository at this point in the history
  • Loading branch information
kaklakariada committed Feb 23, 2022
1 parent c091c58 commit 74ca996
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 3 deletions.
1 change: 1 addition & 0 deletions doc/changes/changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Changes

* [0.6.1](changes_0.6.1.md)
* [0.6.0](changes_0.6.0.md)
* [0.5.0](changes_0.5.0.md)
* [0.4.2](changes_0.4.2.md)
Expand Down
13 changes: 13 additions & 0 deletions doc/changes/changes_0.6.1.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Exasol Tableau Connector 0.6.1, released 2022-02-23

Code name: Support renamed JDBC parameter `logintype`

## Summary

This release updates the JDBC connector and adds support for the renamed parameter `logintype` that will be added with JDBC driver versions 7.1.7 and 8.0.0. The original parameter `loginType` did not follow naming conventions and was undocumented.

The JDBC connector will continue to work with older and newer JDBC drivers by using both variants of the parameter.

## Features

* #48: Added support for renamed JDBC parameter `logintype`
6 changes: 3 additions & 3 deletions javascript-test/jdbc.connectionProperties.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe('Tableau Server', () => {
username: '',
':tableau-server-user': 'tabuser',
password: 'exapassword'
})).toEqual({ user: 'tabuser', loginType: '2' });
})).toEqual({ user: 'tabuser', logintype: 'gss', loginType: '2' });
});

test('Viewer Credentials auth', () => {
Expand All @@ -53,7 +53,7 @@ describe('Tableau Server', () => {
username: '',
':tableau-server-user': 'normaluser',
password: 'exapassword'
})).toEqual({ user: 'normaluser', loginType: '2' });
})).toEqual({ user: 'normaluser', logintype: 'gss', loginType: '2' });
});
});

Expand All @@ -65,5 +65,5 @@ test('Debugging enabled', () => {
':tableau-server-user': 'serveruser',
password: 'exapassword',
'v-debug': 'true'
})).toEqual({ user: 'serveruser', loginType: '2', 'jdbc-driver-debug': "authentication=auth-integrated, workgroup-auth-mode='kerberos-impersonate', username='normaluser', :tableau-server-user='serveruser'"});
})).toEqual({ user: 'serveruser', logintype: 'gss', loginType: '2', 'jdbc-driver-debug': "authentication=auth-integrated, workgroup-auth-mode='kerberos-impersonate', username='normaluser', :tableau-server-user='serveruser'"});
});
1 change: 1 addition & 0 deletions src/exasol_jdbc/connectionProperties.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
} else {
props["user"] = serverUser;
props["loginType"] = "2";
props["logintype"] = "gss";
}

return props;
Expand Down

0 comments on commit 74ca996

Please sign in to comment.