Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* #20: Added a user guide. #21

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

AnastasiiaSergienko
Copy link
Contributor

Closes #20

@AnastasiiaSergienko AnastasiiaSergienko added the documentation User guides, tutorials, specifications label Jul 13, 2021
@AnastasiiaSergienko AnastasiiaSergienko self-assigned this Jul 13, 2021
* Clone the Tableau-Connector repository. You can execute the following command from [Git Bash](https://gitforwindows.org/) terminal:

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```shell

Also for otherts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the snippets so that markdown shows them in the enumeration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also for all other.


```
/bin/bash <path to connector directory>/tableau-connector/tableau-server-GUI-tests/set_up_scripts/package_connector.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that won't work on windows. I guess that most percent of the tableau users use windows, so we should maybe also add a guide for them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or at least mention that you need a linux for those steps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the command I used on Windows actually. I've mentioned that I use Git bash, maybe I can add a note here again about it

Comment on lines 10 to 15

```shell
git clone https://github.com/exasol/tableau-connector.git
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Clone the Tableau-Connector repository. You can execute the following command from [Git Bash](https://gitforwindows.org/) terminal:
```shell
git clone https://github.com/exasol/tableau-connector.git
```
* Clone the Tableau-Connector repository. You can execute the following command from [Git Bash](https://gitforwindows.org/) terminal:
```shell
git clone https://github.com/exasol/tableau-connector.git
```

@jakobbraun jakobbraun self-requested a review July 15, 2021 06:00
Copy link
Contributor

@jakobbraun jakobbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AnastasiiaSergienko AnastasiiaSergienko merged commit 767d1a0 into main Jul 15, 2021
@AnastasiiaSergienko AnastasiiaSergienko deleted the documentation/20_add_user_guide branch July 15, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation User guides, tutorials, specifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a short user guide
2 participants