#137: Use batch insert

exasol · Sep 23, 2024 · 728c368 · 728c368
1 parent 04013c4
commit 728c368
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 7 deletions.
diff --git a/doc/changes/changes_3.5.5.md b/doc/changes/changes_3.5.5.md
@@ -6,10 +6,16 @@ Code name: Fix CVE-2024-7254 in test dependency `com.google.protobuf:protobuf-ja
 
 This release fixes CVE-2024-7254 in test dependency `com.google.protobuf:protobuf-java:3.25.1`.
 
+The release also speeds up inserting rows into a table by using batch insert.
+
 ## Security
 
 * #138: Fixed CVE-2024-7254 in test dependency `com.google.protobuf:protobuf-java:3.25.1`
 
+## Features
+
+* #137: Updated `AbstractImmediateDatabaseObjectWriter#write()` to use batching for inserting rows
+
 ## Dependency Updates
 
 ### Test Dependency Updates

diff --git a/error_code_config.yml b/error_code_config.yml
@@ -2,4 +2,4 @@ error-tags:
   TDBJ:
     packages:
       - com.exasol.dbbuilder
-    highest-index: 34
+    highest-index: 35
diff --git a/src/main/java/com/exasol/dbbuilder/dialects/AbstractImmediateDatabaseObjectWriter.java b/src/main/java/com/exasol/dbbuilder/dialects/AbstractImmediateDatabaseObjectWriter.java
@@ -88,7 +88,8 @@ public void write(final Table table, final Stream<List<Object>> rows) {
         try (final PreparedStatement preparedStatement = this.connection.prepareStatement(sql)) {
             final boolean autoCommitOriginalState = this.connection.getAutoCommit();
             this.connection.setAutoCommit(false);
-            rows.forEach(row -> writeRow(table, sql, preparedStatement, row));
+            rows.forEach(row -> addBatch(table, preparedStatement, row));
+            preparedStatement.executeBatch();
             if (autoCommitOriginalState) {
                 this.connection.commit();
                 this.connection.setAutoCommit(true);
@@ -101,16 +102,15 @@ public void write(final Table table, final Stream<List<Object>> rows) {
         }
     }
 
-    private void writeRow(final Table table, final String sql, final PreparedStatement preparedStatement,
-                            final List<Object> row) {
+    private void addBatch(final Table table, final PreparedStatement preparedStatement, final List<Object> row) {
         try {
             for (int i = 0; i < row.size(); ++i) {
                 preparedStatement.setObject(i + 1, row.get(i));
             }
-            preparedStatement.execute();
+            preparedStatement.addBatch();
         } catch (final SQLException exception) {
-            throw new DatabaseObjectException(table, ExaError.messageBuilder("E-TDBJ-1")
-                    .message("Failed to execute insert query: {{statement}}", sql).toString(), exception);
+            throw new DatabaseObjectException(table,
+                    ExaError.messageBuilder("E-TDBJ-35").message("Failed to row to batch").toString(), exception);
         }
     }