Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sonar findings #15

Closed
AnastasiiaSergienko opened this issue Jan 31, 2019 · 1 comment
Closed

Fix sonar findings #15

AnastasiiaSergienko opened this issue Jan 31, 2019 · 1 comment
Assignees
@AnastasiiaSergienko
Labels
bug Unwanted / harmful behavior

Comments

@AnastasiiaSergienko
Copy link
Contributor

Link to the sonar's check results:
https://sonarcloud.io/dashboard?id=exasol_virtual-schema-common-java
@AnastasiiaSergienko AnastasiiaSergienko added the bug Unwanted / harmful behavior label Jan 31, 2019
redcatbear added a commit that referenced this issue Jan 31, 2019
@redcatbear
#15: Added Sonar badges.
c7e34dc
redcatbear added a commit that referenced this issue Jan 31, 2019
@redcatbear
#15: Removed Java 10 test because it slows down build and does not ad…
e568d42 
…d more confidence than a Java 9 test.
redcatbear added a commit that referenced this issue Jan 31, 2019
@redcatbear
#15: Set Jacoco plug-in version explicitly.
00b464b
redcatbear added a commit that referenced this issue Jan 31, 2019
@redcatbear
#15: Remove sonar properties to find out if they are superfluous.
cd51230
redcatbear added a commit that referenced this issue Jan 31, 2019
@redcatbear
#15: Added encrypted SonarCloud token.
b951873
redcatbear added a commit that referenced this issue Jan 31, 2019
@redcatbear
#15: Removed superfluous "package" target in maven.
067922f
AnastasiiaSergienko added a commit that referenced this issue Feb 1, 2019
@AnastasiiaSergienko
#15: started to fix sonar findings
65e4b19
AnastasiiaSergienko added a commit that referenced this issue Feb 1, 2019
@AnastasiiaSergienko
#15: fixed part of sonar findings
273f4aa
AnastasiiaSergienko added a commit that referenced this issue Feb 1, 2019
@AnastasiiaSergienko
#15: fixed review comments
5a6c8ca
AnastasiiaSergienko added a commit that referenced this issue Feb 1, 2019
@AnastasiiaSergienko
#15: fixed review comments 2
70c0507
@AnastasiiaSergienko AnastasiiaSergienko mentioned this issue Feb 4, 2019
Closed
AnastasiiaSergienko added a commit that referenced this issue Feb 4, 2019
@AnastasiiaSergienko
#15: fixed a part of sonar findings
9f69590
AnastasiiaSergienko added a commit that referenced this issue Feb 4, 2019
@AnastasiiaSergienko
Merge pull request #21 from exasol/15_fixing_sonar_findings_part_2
88ffcfc 
#15: fixed a part of sonar findings
AnastasiiaSergienko added a commit that referenced this issue Feb 5, 2019
@AnastasiiaSergienko
#15: fixed a part of sonar findings
ceff2b3
AnastasiiaSergienko added a commit that referenced this issue Feb 5, 2019
@AnastasiiaSergienko
#15: fixed a part of sonar findings
e7aefa0
AnastasiiaSergienko added a commit that referenced this issue Feb 6, 2019
@AnastasiiaSergienko
Merge pull request #23 from exasol/bug/15_fixing_sonar_findings_part_3
a1c8a6e 
#15: fixed a part of sonar findings
AnastasiiaSergienko added a commit that referenced this issue Feb 13, 2019
@AnastasiiaSergienko
#15: fixed part of code smell
3fab9d5
AnastasiiaSergienko added a commit that referenced this issue Feb 13, 2019
@AnastasiiaSergienko
#15: prepared tests for classes with duplicated code
17ff20b
AnastasiiaSergienko added a commit that referenced this issue Feb 13, 2019
@AnastasiiaSergienko
#15: creates an abstract class to get rid of duplicated code
404d84c
AnastasiiaSergienko added a commit that referenced this issue Feb 13, 2019
@AnastasiiaSergienko
#15: changed the class name
fc0c78b
@AnastasiiaSergienko
Copy link
Contributor Author

Closed with #32

@AnastasiiaSergienko AnastasiiaSergienko self-assigned this Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnastasiiaSergienko AnastasiiaSergienko

Labels
bug Unwanted / harmful behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AnastasiiaSergienko