-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/249 evaluate expected resultset datatype #250
Feature/249 evaluate expected resultset datatype #250
Conversation
src/main/java/com/exasol/adapter/request/parser/DataTypeProperty.java
Outdated
Show resolved
Hide resolved
|
||
public interface JsonEntry { | ||
|
||
public static Group group(final JsonEntry... children) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name Group is a bit misleading. Maybe JsonObject
or JObject
?
|
||
## Summary | ||
|
||
Starting with major version 8 Exasol database uses the capabilities reported by each virtual schema to provide select list data types for each push down request. Based on this information the JDBC virtual schemas no longer need to infer the data types of the result set by inspecting its values. Instead the JDBC virtual schemas can now use the information provided by the database. | ||
|
||
This create a list of benefits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This create a list of benefits | |
This has the following benefits: |
@@ -22,6 +21,11 @@ private String renderChildren(final int level) { | |||
.collect(Collectors.joining(",\n" + indent(level), indent(level), "")); | |||
} | |||
|
|||
public JsonParent withChild(final JsonEntry child) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public JsonParent withChild(final JsonEntry child) { | |
public JsonParent addChild(final JsonEntry child) { |
❓
Kudos, SonarCloud Quality Gate passed! |
fixes #249