Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/249 evaluate expected resultset datatype #250

Merged
merged 10 commits into from
Sep 9, 2022

Conversation

ckunki
Copy link
Collaborator

@ckunki ckunki commented Sep 8, 2022

fixes #249

enhanced parser, added unit tests
some questions remain, see ticket
doc/changes/changes_16.0.0.md Outdated Show resolved Hide resolved

public interface JsonEntry {

public static Group group(final JsonEntry... children) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name Group is a bit misleading. Maybe JsonObjector JObject?


## Summary

Starting with major version 8 Exasol database uses the capabilities reported by each virtual schema to provide select list data types for each push down request. Based on this information the JDBC virtual schemas no longer need to infer the data types of the result set by inspecting its values. Instead the JDBC virtual schemas can now use the information provided by the database.

This create a list of benefits
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This create a list of benefits
This has the following benefits:

@@ -22,6 +21,11 @@ private String renderChildren(final int level) {
.collect(Collectors.joining(",\n" + indent(level), indent(level), ""));
}

public JsonParent withChild(final JsonEntry child) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public JsonParent withChild(final JsonEntry child) {
public JsonParent addChild(final JsonEntry child) {

@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ckunki ckunki merged commit 332f400 into main Sep 9, 2022
@ckunki ckunki deleted the feature/249-evaluate-expected-resultset-datatype branch September 9, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate expected result datatypes from json
2 participants