Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sheets with hyperlinks and data validations are corrupted #256

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Sheets with hyperlinks and data validations are corrupted #256

merged 1 commit into from
Feb 15, 2017

Conversation

simon-stoic
Copy link
Contributor

I was trying to convert a file that had both an hyperlink and data validations. For some obscure reason, Excel didn't want to open the resulting file. Putting the links after the data validations in the sheet's XML fixed the issue.
I'm not familiar enough with exceljs to write a test for this issue.

@guyonroche
Copy link
Collaborator

Good catch. Don't worry, I'll add a unit test for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants