-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📚 DOCS: Add reference to MySTyc in landing page #413
Conversation
Rendered version: https://myst-parser--413.org.readthedocs.build/en/413/ |
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
=======================================
Coverage 90.67% 90.67%
=======================================
Files 14 14
Lines 1855 1855
=======================================
Hits 1682 1682
Misses 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
thanks for the cool product @astrojuanlu! I'd note that higher up the page there is: |
Thanks @chrisjsewell ! Not sure if this is what you had in mind, WDYT? |
yeh I think possibly so thanks. We could put it lower down, where you had it before, in the "Get started with MyST" panel, what do you think @choldgraf? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - I think it's nice to have it in a prominent spot, though not super invasive.
My one concern is maintenance of the service over time. What are the odds that in 3 months somebody will click the link and the heroku app will be down? If folks don't think that is a significant possibility then I'm +1 on the change
The service is running on my personal Heroku account on the free dyno ( $0.00/month ). Out of the 1000 free dyno hours granted for verified accounts, MySTyc has spent 9.68 hrs this month. I have no intention of taking it down anytime soon. However, there is a chance someone might abuse the app, or that someday it suffers an orange-site-calypse. If the app exhausts the free hours, my plan is to just scale it down temporarily until the beginning of the following month. If this is not acceptable to folks, here are some ideas:
We could also give the app a domain name, so if it ever moves away from Heroku, the URL is unchanged. It costs money upfront, doesn't solve the underlying issue. All of this sounds like not very appealing for a weekend hack, but I understand that you want to have some confidence on what you put on the front page. I'm open to suggestions here :) |
Hey @astrojuanlu - sorry for the slow response on that latest point. In my opinion, we shouldn't block this PR on battle-testing that heroku app. It's useful and cool, and even if it goes down at some point, at worst people will just open an issue about it, and we can remove the link in the future. So I think the next step here is to just implement the location swap that @astrojuanlu mentions here: #413 (comment) and then give it a whirl :-) |
No worries @choldgraf ! The swap was already done in the last commit I think :D |
Yeh that's good for me cheers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great - thanks @astrojuanlu for the improvement!
Ref: https://twitter.com/juanluisback/status/1419626473787469824
Encouraged by @pradyunsg and @chrisjsewell 🚀