Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX: Convert empty directive option to None #452

Merged
merged 1 commit into from
Dec 4, 2021

Conversation

chrisjsewell
Copy link
Member

fixes #431

@chrisjsewell chrisjsewell changed the title 🐛 FIX: Convert empty directive option to null 🐛 FIX: Convert empty directive option to None Dec 4, 2021
@codecov
Copy link

codecov bot commented Dec 4, 2021

Codecov Report

Merging #452 (715a85a) into master (89ad170) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #452   +/-   ##
=======================================
  Coverage   90.80%   90.80%           
=======================================
  Files          16       16           
  Lines        1881     1881           
=======================================
  Hits         1708     1708           
  Misses        173      173           
Flag Coverage Δ
pytests 90.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_parser/parse_directives.py 88.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ad170...715a85a. Read the comment docs.

@chrisjsewell chrisjsewell merged commit ea6e967 into master Dec 4, 2021
@chrisjsewell chrisjsewell deleted the fix-null-option branch December 4, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional int directive option incorrectly passed as empty string, not None
1 participant