Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation/french: suggest edit, open issue #283

Closed
wants to merge 2 commits into from

Conversation

Naereen
Copy link

@Naereen Naereen commented Feb 9, 2021

Hello there,
A tiny contribution to this sphinx-book-theme:

  • The current translation was the same as "open issue" -> "problème ouvert" (which is also wrong, see next commit),
  • The current translation of "open issue" -> "problème ouvert" was wrong (it interprets "open" as an adjective and not a verb).

Thanks in advance, regards! -- @Naereen

The current translation was the same as "open issue" -> "problème ouvert" (which is also wrong, see next commit)
The current translation of "open issue" -> "problème ouvert" was wrong (it interprets "open" as an adjective and not a verb),
@welcome
Copy link

welcome bot commented Feb 9, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@chrisjsewell
Copy link
Member

chrisjsewell commented Feb 9, 2021

thanks @Naereen! Looks like the "suggest edit" was accidentally a copy of "open issue" 🤦 . I've opened #284 and added your suggestions to it, since you also have to create the binary files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants