Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #53 from mgeier/remove-dependencies #53

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

mgeier
Copy link
Contributor

@mgeier mgeier commented Jan 17, 2020

Is flit really needed when installing with pip?

setuptools has already been imported further up in the file, so installing it now would be a bit late ...

I guess wheel is only needed when building bdist_wheel, but not for normal pip installing, right?

And I guess users will want Sphinx if they install this module, but I don't think it should be a formal dependency.

I'm not sure about the last point in the case where only a subset of Sphinx versions are supported, but this is not the case here anyway.

@choldgraf
Copy link
Member

yep, this all makes sense to me, thanks for this! Flit is an old dependency :-)

thanks!

@choldgraf choldgraf changed the title Remove unnecessary dependencies Merge pull request #53 from mgeier/remove-dependencies Jan 17, 2020
@choldgraf choldgraf merged commit 7ab8831 into executablebooks:master Jan 17, 2020
@mgeier mgeier deleted the remove-dependencies branch January 17, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants