-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RemovedInSphinx90Warning ("The str interface for _JavaScript objects is deprecated") #197
Labels
Comments
I think changing the title to include "str interface for _JavaScript" would make this issue a bit more visible and precise. |
ru-fu
changed the title
RemovedInSphinx90Warning
RemovedInSphinx90Warning ("The str interface for _JavaScript objects is deprecated")
Aug 19, 2024
kartben
added a commit
to kartben/sphinx-tabs
that referenced
this issue
Aug 20, 2024
Fixes executablebooks#197 by reversing the logic of how JS/CSS assets are added to pages. Rather than adding assets to the app and using undocumented API to *remove* them when not needed, do the exact opposite and only add them to the local html-page-context when building a page. Signed-off-by: Benjamin Cabé <[email protected]>
kartben
added a commit
to kartben/sphinx-tabs
that referenced
this issue
Aug 20, 2024
Fixes executablebooks#197 by reversing the logic of how JS/CSS assets are added to pages. Rather than adding assets to the app and using undocumented API to *remove* them when not needed, do the exact opposite and only add them to the local html-page-context when building a page. Signed-off-by: Benjamin Cabé <[email protected]>
My understanding is that there should have been no dependency on internal/undocumented API in the first place. PR #198 is taking a stab at fixing this issue -- would be great to get some help reviewing it and potentially getting a release with the fix out. Thanks! |
kartben
added a commit
to kartben/sphinx-tabs
that referenced
this issue
Aug 20, 2024
Fixes executablebooks#197 by reversing the logic of how JS/CSS assets are added to pages. Rather than adding assets to the app and using undocumented API to *remove* them when not needed, do the exact opposite and only add them to the local html-page-context when building a page. Signed-off-by: Benjamin Cabé <[email protected]>
kartben
added a commit
to kartben/sphinx-tabs
that referenced
this issue
Aug 20, 2024
Fixes executablebooks#197 by reversing the logic of how JS/CSS assets are added to pages. Rather than adding assets to the app and using undocumented API to *remove* them when not needed, do the exact opposite and only add them to the local html-page-context when building a page. Signed-off-by: Benjamin Cabé <[email protected]>
kartben
added a commit
to kartben/sphinx-tabs
that referenced
this issue
Aug 21, 2024
Fixes executablebooks#197 by reversing the logic of how JS/CSS assets are added to pages. Rather than adding assets to the app and using undocumented API to *remove* them when not needed, do the exact opposite and only add them to the local html-page-context when building a page. Signed-off-by: Benjamin Cabé <[email protected]>
kartben
added a commit
to kartben/sphinx-tabs
that referenced
this issue
Aug 21, 2024
Fixes executablebooks#197 by reversing the logic of how JS/CSS assets are added to pages. Rather than adding assets to the app and using undocumented API to *remove* them when not needed, do the exact opposite and only add them to the local html-page-context when building a page. Signed-off-by: Benjamin Cabé <[email protected]>
simondeziel
added a commit
to simondeziel/lxd
that referenced
this issue
Oct 1, 2024
Workaround executablebooks/sphinx-tabs#197 Signed-off-by: Simon Deziel <[email protected]>
tomponline
added a commit
to canonical/lxd
that referenced
this issue
Oct 2, 2024
tomponline
pushed a commit
to tomponline/lxd
that referenced
this issue
Oct 8, 2024
Workaround executablebooks/sphinx-tabs#197 Signed-off-by: Simon Deziel <[email protected]> (cherry picked from commit 4c0b4bd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When building with Sphinx 8.x, sphinx-tabs gives the following errors:
These aren't actually Sphinx errors and don't cause the build to fail, but I haven't figured out how to filter them out, so they make the build log unreadable.
And it will probably render sphinx-tabs unusable in Sphinx 9.x.
Seems the deprecation message has been introduced in this commit: sphinx-doc/sphinx@49dc0dd
Reproduce the bug
Build a doc set that includes tabs with Sphinx 8.x.
List your environment
No response
The text was updated successfully, but these errors were encountered: