Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace six from django.utils with the external package #2

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

KBenas
Copy link

@KBenas KBenas commented Feb 10, 2020

Django has removed six from django.utils package in order to drop support for Python 2:
https://docs.djangoproject.com/en/3.0/releases/3.0/#removed-private-python-2-compatibility-apis

All Django projects that use django-softdelete-it cannot be upgraded to 3.0 since six library is missing. A quick way to fix the issue is to replace six with the external package.

@exploreshaifali
Copy link
Owner

Hi @KBenas ,

Thanks for PR. Changes are fixing the issue for Python3 and are also working in Python2.

Please can you also change the version to 0.2 in setup file.

Also, I have created dev branch. So please can you update the PR to get merge into dev branch.

Thanks!

@KBenas KBenas changed the base branch from master to dev October 20, 2020 05:38
@KBenas
Copy link
Author

KBenas commented Oct 20, 2020

Hello @exploreshaifali,

Sorry for late response. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants