-
Notifications
You must be signed in to change notification settings - Fork 88
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add eslint rule to reduce node-fetch usage
- Loading branch information
Showing
2 changed files
with
7 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,6 +29,10 @@ module.exports = { | |
name: 'lodash', | ||
message: "Don't use lodash, it's heavy!", | ||
}, | ||
{ | ||
name: 'node-fetch', | ||
message: 'Use got instead, node-fetch is used only for the GraphQL client.', | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
dsokal
Author
Contributor
|
||
}, | ||
], | ||
}, | ||
], | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From following nodejs/node#19393 it seems like☺️
fetch
being included in a future Node.js version is very likely, and might happen quite soon! If you transition to using node-fetch instead of got it will be very easy to not have a dependency at all once you drop support for older versions of Node.js