fix(snackager): add e2e bundling test for [email protected]
#621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
changed the title
[email protected][email protected]
byCedric
force-pushed
the
@bycedric/snackager/fix-react-native-webview
branch
2 times, most recently
from
580978c to
c9522d5
Compare
byCedric
force-pushed
the
@bycedric/snackager/fix-react-native-webview
branch
from
c9522d5 to
8d2e7e3
Compare
|
thanks for fixing the problem. the EventEmitter from react-native-webview was imported by me 😅 |
|
So... IT WAS YOU! Just kidding, Snackager should be able to parse any type of Flow code anyways -- happy to fix it. |
henryz2004
added a commit
to henryz2004/snack
that referenced
this pull request
Jan 12, 2025
…[email protected]` (expo#621)" This reverts commit 6aaf5c4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
[email protected]imports the vendored event emitter file fromreact-native. This file unfortunately uses syntax that can't be parsed by the Babel flow parser ([key in keyof TEventToArgsMap]). To combat that, this PR adds the Hermes babel plugin for flow code.How
[email protected]to SnackagerTest Plan
See E2E tests